Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing capabilities #8

Closed
amyramos opened this issue Jan 16, 2021 · 2 comments · Fixed by #9
Closed

Add signing capabilities #8

amyramos opened this issue Jan 16, 2021 · 2 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@amyramos
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Maybe it will be a great feature to have an opportunity to add signatures to data stored in the database. So, it will be possible to verify integrity of data stored in the database on the client side. It can be used to determine if there were changes of the signed data.

Describe the solution you'd like
Add a new structure called SignedValue which will use SignatureAlgorithms variable and as EncryptedValue use the first algorithm to sign data and use other algorithms with lower priority (fallbacks) if it's not possible to verify signature with the first (primary) algorithm. Example SignedValue struct based on EncryptedValue:

type SignedValue struct {
    Raw   interface{} `json:"Raw"`
    Valid bool        `json:"Valid"`
}

Raw is value which is stored in the database, Valid is boolean which tells if the Raw value is signed correctly.

@amyramos amyramos added the enhancement New feature or request label Jan 16, 2021
@amyramos
Copy link
Contributor Author

@pkosilo, I'd like to work on it myself

@pkasila
Copy link
Owner

pkasila commented Jan 16, 2021

@pkosilo, I'd like to work on it myself

Okay 👍

pkasila pushed a commit that referenced this issue Jan 16, 2021
@amyramos amyramos mentioned this issue Jan 16, 2021
@pkasila pkasila linked a pull request Jan 16, 2021 that will close this issue
@pkasila pkasila added this to the v. 0.2.0 milestone Jan 16, 2021
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
…d tests

add and update tests for ECDSA and Ed25519 signing algorithms (pkasila#8 and pkasila#11)
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants