Root directory passed to NewServer is never used or acted on

[sykesm]

The NewServer constructor accepts and propagates a rootDir argument to the Server but the location is never used after construction. What was the intent of the argument? Could/should it be treated as the default working directory for the server instance?

[sykesm]

Looks like #56 was related. I'd like to see the behavior described by @marksheahan implemented as we have linked the sftp server into an ssh daemon and would like to be able to set the default working directory of each instance to the home directory of the user. If this behavior is not implemented in the server, we will have to create a separate sftp server executable and exec it with the appropriate working directory.

If you're interested in a PR, I'd be happy to change the name of the argument to the constructor and make the necessary implementation changes.

Thanks.

[sykesm]

Given the confusion over the meaning of the rootDir on the constructor and the fact that it's not implemented, perhaps it makes sense to remove it completely?

[davecheney]

Yes, please remove it, then we can start from a fresh slate. Thanks

On Thu, 14 Jan 2016, 22:24 Matthew Sykes notifications@github.com wrote:

Given the confusion over the meaning of the rootDir on the constructor
and the fact that it's not implemented, perhaps it makes sense to remove it
completely?

—
Reply to this email directly or view it on GitHub
#65 (comment).

[mdlayher]

Sounds good to me as well. I somehow didn't catch that it was totally unused when I was making my PRs. Apologies for that.

[sykesm]

Addressed with 8e47c75.