Manually marshal packets for more speed #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good except for one problem, types_like_this_are_not_considered_idiomatic, please use sftpSomethingSomethingSomething. |
|
Reworked initial commit for CamelCase over underscore_case and added a |
| func sendPacket(w io.Writer, m encoding.BinaryMarshaler) error { | ||
| bb, err := m.MarshalBinary() | ||
| if err != nil { | ||
| return errors.New(fmt.Sprintf("marshal2(%#v): binary marshaller failed", err)) |
|
LGTM. Just one little nit then I can merge this. Thank you for this, it will help #15 a lot. |
|
Wow, didn't know about |
davecheney
added a commit
that referenced
this pull request
Sep 28, 2014
Manually marshal packets for more speed
|
Lovely. Thanks a lot. |
This was referenced Sep 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the
sendPacketfunction to accept aencoding.BinaryMashalerand implement the relatedMarshalBinaryfunction on each packet type. This gives us great speed and allocation wins (see #16) at the expense of less readability, albeit one-time only.