Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getwd to client #58

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Add Getwd to client #58

merged 1 commit into from
Dec 23, 2015

Conversation

sykesm
Copy link
Contributor

@sykesm sykesm commented Dec 21, 2015

Realpath is useful when working with relative paths and it helps users of the client keep track of the current working directory.

@davecheney
Copy link
Member

Thank you for this PR. Can you please raise a bug describing the problem you have, and link it to this PR as a solution.

Thanks

Dave

@sykesm
Copy link
Contributor Author

sykesm commented Dec 22, 2015

@davecheney sure. Issue raised.

If you prefer to have issues raised before pull requests, you might want to add that information to the contributing section of the README.

Thanks.

@davecheney
Copy link
Member

Thanks. I'll make sure I update the contributing info in the readme. I've
been a bit slack about doing that for my projects. Sorry about that.

On Tue, 22 Dec 2015, 14:37 Matthew Sykes notifications@github.com wrote:

@davecheney https://github.com/davecheney sure. Issue raised.

If you prefer to have issues raised before pull requests, you might want
to add that information to the contributing section of the README.

Thanks.


Reply to this email directly or view it on GitHub
#58 (comment).

@davecheney
Copy link
Member

Thanks for raising #59. Can you please change this PR to add something like client.Getwd() (string, error) to match the os package function of the same name.

You could do this by taking your Realpath method, making it private to the client then adding Getwd as a public method. Then if we need Realpath later on, we can export it.

@sykesm
Copy link
Contributor Author

sykesm commented Dec 22, 2015

Please let me know if this is closer to what you were looking for. Thanks.

@sykesm sykesm changed the title Add Realpath to client Add Getwd to client Dec 22, 2015
@davecheney
Copy link
Member

LGTM thanks.

davecheney added a commit that referenced this pull request Dec 23, 2015
@davecheney davecheney merged commit 739c35a into pkg:master Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants