-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): lock file maintenance #31
base: main
Are you sure you want to change the base?
Conversation
ec8714f
to
38d2aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right. Not sure why renovate removes all the integrity fields - will investigate later.
38d2aba
to
2c7dda1
Compare
2c7dda1
to
4291345
Compare
4291345
to
30c7fcb
Compare
This is not renovate doing it - it's npm. And npm seems to do it, because renovate effectively re-runs One could argue this is a bug on npm side, but I can also see this being declared a "won't fix" (I wouldn't hold my breath for a fix anyways), so probably it should be up to renovate to remove Not sure where best to raise an issue (or possibly in both places). Will have to think about this a little. |
I think it is a matter of renovate Node.js runtime. https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#lockfileversion Both (the original and the edited package-lock) are processed by npm>=7 Maybe a re-run solve the issue |
No, re-running or changing lockfile version does not help. I was able to reproduce locally. Ideally, renovate would support wiping node_modules before renovation, and checking in after. I'll probably raise an issue there. |
30c7fcb
to
014f911
Compare
Created an issue on renovate side: renovatebot/renovate#13926. Also checked if there's any packages to be updated - there are none at the moment. |
014f911
to
12b5d32
Compare
12b5d32
to
452fff5
Compare
452fff5
to
2e93458
Compare
2e93458
to
5e65f83
Compare
Sorry, I bet this was one of those ones I accidentally closed. I had this repo open looking at the pkgjs/create-pkg repo and just got confused. |
No worries! |
5e65f83
to
7ab5771
Compare
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.