[OMP Native Import/Export Plugin v3.2 #775
Conversation
plugins/importexport/native/filter/MonographFileNativeXmlFilter.inc.php
Outdated
Show resolved
Hide resolved
| * Constructor | ||
| * @param $filterGroup FilterGroup | ||
| */ | ||
| function __construct($filterGroup) { |
| * @param $document DOMDocument|string | ||
| * @return array Array of imported documents | ||
| */ | ||
| function &process(&$document) { |
There was a problem hiding this comment.
I think this can be removed...
| * Constructor | ||
| * @param $filterGroup FilterGroup | ||
| */ | ||
| function __construct($filterGroup) { |
| } | ||
| // if ($publication->getData('subtitle')) { | ||
| // $titleElementNode->appendChild($this->_buildTextNode($doc, 'Subtitle', $publication->getData('subtitle'))); | ||
| // } |
There was a problem hiding this comment.
Is this commented for a reason?
There was a problem hiding this comment.
$publication->getData('subtitle') is an array (localized), and _buildTextNode expects string. I was looking for alternatives here
There was a problem hiding this comment.
ONIX is not multilingual-capable, so I would suggest using the values for the submission's locale. (Generally we should also be avoiding getLocalizedData because it gets the content based on the current user's locale -- exports should not depend on the user's language, so getData('subtitle', $publication->getData('locale')) is preferred.)
| * Get the publication node name | ||
| * @return string | ||
| */ | ||
| function getPublicationNodeName() { |
There was a problem hiding this comment.
I don't think this abstraction adds anything, since we're using publication (and publications) throughout -- I think this pattern comes from cases where we need different element names (article in OJS, monograph in OMP). So I'd suggest removing it.
There was a problem hiding this comment.
[removed from OJS and pkp-lib, can remove here without anything more]
No description provided.