Initial draft of 3.4 release notebook

[NateWr]

No description provided.

[withanage]

@NateWr somethings, which comes to my mind , specially related to plugins, which may be relevant, specially for admins who have their own plugins

• Plugins shold also have the language folders 'en' etc.
• Email sending rewrite , if plugins send emails. e.g. is in orcidProfile Plugin. You have to reinstall the plugin to get the new keys installed into the email_templates_default_data table.
• namespacing and removing .inc. extension also for plugins for optimizing

[NateWr]

Thanks @withanage. Can you say more about this?

Email sending rewrite , if plugins send emails. e.g. is in orcidProfile Plugin. You have to reinstall the plugin to get the new keys installed into the email_templates_default_data table.

The system should port over any existing emails, but maybe something is missing here?

[withanage]

Thanks @withanage. Can you say more about this?

Email sending rewrite , if plugins send emails. e.g. is in orcidProfile Plugin. You have to reinstall the plugin to get the new keys installed into the email_templates_default_data table.

The system should port over any existing emails, but maybe something is missing here?

For me the name attribute was missing in the orcidProfile Plugin emailTemplates.xml , until then the emails did not work. Vitaliey helped me finding that, may be if plugin developers do have emailTemplates.xml which does not have a name attribute , it shold fail.

[jonasraoni]

You may need to update the locale setting in the [i18n] section of config.inc.php

I think it might be worth to add a pre-flight check for this :)

[NateWr]

For me the name attribute was missing

Hmm, do you remember what the error was? The upgrade migration is supposed to automatically add a name value for every template, even if one is not defined.

https://github.com/pkp/pkp-lib/blob/84c5a17c958948a4d5b29bdbd935c89ff835d17a/classes/migration/upgrade/v3_4_0/I5716_EmailTemplateAssignments.php#L252-L260

Do you know if you ran the I5716_EmailTemplateAssignments migration when you encountered the error? It should be run during the normal upgrade process...