Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReverseSequence op #1579

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Add ReverseSequence op #1579

merged 5 commits into from
Dec 4, 2020

Conversation

XingHongChenIntel
Copy link
Contributor

@XingHongChenIntel XingHongChenIntel commented Nov 27, 2020 •
edited by YangleiZouIntel
Loading

Added ReverseSequence op, and requires changes in plaidml/openvino, please see plaidml/openvino#116.

@YangleiZouIntel YangleiZouIntel changed the title Add ReverseSequence op for bridge/openvino Add ReverseSequence op Nov 27, 2020
tzerrell
tzerrell reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it is unfortunate (from a perf & clarity of code perspective) that we need to repeatedly slice & concatenate to accomplish this. However, I don't currently see a way around doing so. I will continue thinking on this but it looks reasonable for now.

@tzerrell tzerrell mentioned this pull request Dec 1, 2020
Closed
@XingHongChenIntel XingHongChenIntel force-pushed the flex-ReverseSequence-op branch 2 times, most recently from b0e3c07 to a21e2c6 Compare December 4, 2020 02:04
@XingHongChenIntel
Copy link
Contributor Author

Hmm, it is unfortunate (from a perf & clarity of code perspective) that we need to repeatedly slice & concatenate to accomplish this. However, I don't currently see a way around doing so. I will continue thinking on this but it looks reasonable for now.

since we have gather op, I replaced slice op by gather op. After testing, it speed up all test process.

@YangleiZouIntel YangleiZouIntel marked this pull request as ready for review December 4, 2020 11:28
tzerrell
tzerrell approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I agree this is a better approach.

@mergify mergify bot merged commit b5eaa15 into plaidml-v1 Dec 4, 2020
@mergify mergify bot deleted the flex-ReverseSequence-op branch December 4, 2020 22:12
XinWangIntel added a commit to Flex-plaidml-team/plaidml that referenced this pull request Dec 9, 2020
@XinWangIntel
Revert "Add ReverseSequence op (plaidml#1579)"
122774c 
This reverts commit b5eaa15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzerrell tzerrell tzerrell approved these changes

@flaub flaub Awaiting requested review from flaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XingHongChenIntel @tzerrell