Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix action evaluation results in v100240 #1212

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

area363
Copy link
Member

@area363 area363 commented Jul 15, 2022

When we updated the mainnet version from v230 to v240, there were some deployment errors which ended up causing blocks from #4374157 and #4377430 to be evaluated differently compared to the canonical chain. I've narrowed down the specific actions (Buy11, CombinationEquipment11, HackAndSlashSweep4, ItemEnhancement10, RankingBattle, and RapidCombination6) causing these problems and added conditions that would allow the execution results to match the canonical chain.

@area363 area363 added the bug Something isn't working label Jul 15, 2022
@area363 area363 self-assigned this Jul 15, 2022
@area363
Copy link
Member Author

area363 commented Jul 15, 2022

I'll fix the tests first.

@area363 area363 force-pushed the fix-action-evaluation branch 2 times, most recently from db603a1 to c42e5fa Compare August 1, 2022 13:45
@longfin longfin linked an issue Aug 5, 2022 that may be closed by this pull request
@pull-request-quantifier-deprecated

This PR has 39 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +33 -6
Percentile : 15.6%

Total files changed: 7

Change summary by file extension:
.cs : +33 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@area363
Copy link
Member Author

area363 commented Aug 11, 2022

@planetarium/9c-dev @planetarium/9c-backend PTAL, this fix has been tested by appending blocks #4133000 to #4380000. 🙏

@area363 area363 merged commit 6490095 into development Aug 12, 2022
@hskim881028 hskim881028 deleted the fix-action-evaluation branch December 20, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Extra Small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

InvalidRootHashException on #4133443
2 participants