-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix action evaluation results in v100240
#1212
Conversation
I'll fix the tests first. |
db603a1
to
c42e5fa
Compare
c42e5fa
to
d9f322e
Compare
3487ebd
to
d4c76b3
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@planetarium/9c-dev @planetarium/9c-backend PTAL, this fix has been tested by appending blocks |
When we updated the mainnet version from
v230
tov240
, there were some deployment errors which ended up causing blocks from#4374157
and#4377430
to be evaluated differently compared to the canonical chain. I've narrowed down the specific actions (Buy11
,CombinationEquipment11
,HackAndSlashSweep4
,ItemEnhancement10
,RankingBattle
, andRapidCombination6
) causing these problems and added conditions that would allow the execution results to match the canonical chain.