Move block validation code to BlockChain<T> #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
requested review from
dahlia,
longfin,
limebell,
riemannulus and
moreal
dahlia
previously approved these changes
Sep 18, 2020
| <TargetFramework>netcoreapp3.0</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(MSBuildRuntimeType)'=='Mono' And | ||
| '$(BuildingByReSharper)'!='true'"> | ||
| <PropertyGroup Condition=" '$(MSBuildRuntimeType)'=='Mono' And '$(BuildingByReSharper)'!='true'"> |
There was a problem hiding this comment.
The changes in this file are apparently unnecessary.
There was a problem hiding this comment.
You're right, but I changed it because Rider modifies this file whenever I add or remove files.
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
earlbread
force-pushed
the
block-validation
branch
from
ab7fa85
to
11d8bfe
Compare
longfin
approved these changes
Sep 18, 2020
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 88.94% 88.89% -0.05%
==========================================
Files 329 330 +1
Lines 29892 29883 -9
==========================================
- Hits 26586 26565 -21
- Misses 1741 1748 +7
- Partials 1565 1570 +5
|
moreal
approved these changes
Sep 18, 2020
dahlia
approved these changes
Sep 18, 2020
limebell
approved these changes
Sep 18, 2020
moreal
added a commit
to moreal/libplanet
that referenced
this pull request
Dec 11, 2020
`BlockPolicy.ValidateNextBlock` has been become not to throw `InvalidBlockStateRootHashException` since planetarium#1010
moreal
added a commit
to moreal/libplanet
that referenced
this pull request
Dec 11, 2020
`BlockPolicy.ValidateNextBlock` has been become not to throw `InvalidBlockStateRootHashException` since planetarium#1010 [skip changelog]
Merged
moreal
added a commit
to moreal/libplanet
that referenced
this pull request
Dec 11, 2020
`BlockPolicy.ValidateNextBlock` has been become not to throw `InvalidBlockStateRootHashException` since planetarium#1010 [skip changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves block validation code to
BlockChain<T>fromBlockPolicy<T>and also the methods ofBlockPolicy<T>became to virtual so that it can be overridden.