Simplify swarm interface #72
Conversation
longfin
force-pushed
the
feature/simplify-swarm-interface
branch
from
eb0ce6f
to
357c3cd
Compare
Libplanet.Tests/Net/SwarmTest.cs
Outdated
| await swarm.StopAsync(); | ||
|
|
||
| Assert.False(swarm.Running); | ||
| await t; |
There was a problem hiding this comment.
We would be able (and indeed it's good) to test what if StopAsync() is called when it's not Running.
| @@ -261,33 +227,32 @@ public void CopyTo(Peer[] array, int arrayIndex) | |||
| } | |||
| } | |||
|
|
|||
| public async Task DisposeAsync( | |||
| public async Task StopAsync( | |||
There was a problem hiding this comment.
I predict that library users will tend to forget to call this after they started a swarm, in the similar way to forget fclose() in C. How about Swarm having a finalizer (i.e., ~Swarm()) and making it to call StopAsync() with a warning if it's Running? Python also does a similar thing for file objects.
There was a problem hiding this comment.
Since StopAsync() is an asynchronous function, I'm not sure if it can wait in the finalizer...
There was a problem hiding this comment.
Indeed. Make sense. So can we log a warning at least if a Swarm object is finalized but still Running?
| Blockchain<BaseAction> chain = _blockchains[0]; | ||
| Task t = Task.Run(async () => | ||
| { | ||
| await swarm.StartAsync(chain, 250); |
There was a problem hiding this comment.
As a separated case, it seems good to test if SwarmException rises when a swarm tries to call StartAsync() twice (i.e., calling StartAsync() when it is already Running).
| Blockchain<T> blockchain, | ||
| int distributeInterval, | ||
| TimeSpan distributeInterval, |
longfin
force-pushed
the
feature/simplify-swarm-interface
branch
4 times, most recently
from
7447aac
to
712f065
Compare
- remove _delta and ProcessDeltaAsync in worker task.
longfin
force-pushed
the
feature/simplify-swarm-interface
branch
from
712f065
to
09eb0cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 86.41% 86.28% -0.13%
==========================================
Files 60 60
Lines 2672 2684 +12
==========================================
+ Hits 2309 2316 +7
- Misses 363 368 +5
|
…0-nightly-20191022 Bump libplanet to 0.7.0-nightly.20191022
…manifests-1667869217 Update manifests [update-rc-v100321-manifests-1667869217]
This PR simplifies
Swarm's interface as #69. specifically, the following changes have been made.RunAsync()/DisposeAsync()toStartAsync()/StopAsync()InitContextAsync()intoRunAsync()_deltaqueue and replace related logic with worker task.