Replace to use RocksDB for Tx Nonce and Canonical Chain ID #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 86.92% 86.98% +0.06%
==========================================
Files 237 239 +2
Lines 21245 21319 +74
==========================================
+ Hits 18467 18545 +78
- Misses 1456 1457 +1
+ Partials 1322 1317 -5
|
earlbread
force-pushed
the
replace-litedb-1
branch
from
db4e85d
to
cfc2f7f
Compare
longfin
requested changes
Feb 28, 2020
earlbread
force-pushed
the
replace-litedb-1
branch
from
cfc2f7f
to
e62c126
Compare
longfin
previously approved these changes
Feb 28, 2020
dahlia
reviewed
Feb 28, 2020
earlbread
force-pushed
the
replace-litedb-1
branch
from
e62c126
to
940cd81
Compare
earlbread
force-pushed
the
replace-litedb-1
branch
from
940cd81
to
258eca6
Compare
longfin
previously approved these changes
Feb 28, 2020
dahlia
reviewed
Feb 28, 2020
CHANGES.md
Outdated
Comment on lines
13
to
14
| - Extension classes have been renamed. However, it is not affected | ||
| if you do not call it directly. [[#803]] |
There was a problem hiding this comment.
Suggested change
| - Extension classes have been renamed. However, it is not affected | |
| if you do not call it directly. [[#803]] | |
| - Extension classes was renamed. However, it would not be affected | |
| if you have called it by using instance method syntax. [[#803]] |
There was a problem hiding this comment.
My mistake. Restored it.
|
/rebase |
earlbread
force-pushed
the
replace-litedb-1
branch
from
5b53309
to
a61b544
Compare
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
dahlia
approved these changes
Feb 28, 2020
longfin
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces to use RocksDB for Tx Nonce and Canonical Chain ID in
Libplanet.RocksDBStore. The remainder of using LiteDB will be replaced in the next PRs.