Remove/hide unused public interfaces #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is never thrown up to user-faced API
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 87.48% 87.49%
=======================================
Files 249 249
Lines 22520 22520
=======================================
+ Hits 19702 19703 +1
+ Misses 1473 1471 -2
- Partials 1345 1346 +1
|
longfin
reviewed
Mar 31, 2020
As this option seems never used by client code
dahlia
force-pushed
the
different-app-protocol-version-exception
branch
from
52ec174
to
6dd215e
Compare
longfin
approved these changes
Apr 1, 2020
moreal
approved these changes
Apr 1, 2020
earlbread
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also the commit messages and changelogs.