Parallelizing Swarm<T>.PreloadAsync() #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
bugfix/slow-preload
branch
from
a109bfc
to
2f483c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 87.51% 87.50% -0.02%
==========================================
Files 249 249
Lines 22601 22620 +19
==========================================
+ Hits 19779 19793 +14
- Misses 1477 1481 +4
- Partials 1345 1346 +1
|
earlbread
previously approved these changes
Apr 10, 2020
Libplanet/Net/Swarm.cs
Outdated
| { | ||
| return (peer, pong); | ||
| } | ||
| }) |
There was a problem hiding this comment.
How about adding the cancellationToken to ContinueWith?
Libplanet/Net/Swarm.cs
Outdated
| } | ||
|
|
||
| return t.Result.Where(pair => !(pair.Item1 is null)).ToArray(); | ||
| }); |
There was a problem hiding this comment.
How about adding the cancellationToken to ContinueWith?
Libplanet/Net/Swarm.cs
Outdated
| else if (!(t.Result is Pong pong)) | ||
| { | ||
| // Mark to skip | ||
| return (null, null); |
There was a problem hiding this comment.
How about combining these multiple conditions into one?
longfin
force-pushed
the
bugfix/slow-preload
branch
from
2f483c7
to
7d7bf04
Compare
|
Amended a commit to applying the suggestion (7d7bf04) |
earlbread
approved these changes
Apr 10, 2020
dahlia
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the performance of
Swarm<T>.PreloadAsync()by parallelizingDialToExistingPeers().