Fixed a bug where the canonical chain was changed during preload #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.9-maintenance #862 +/- ##
==================================================
Coverage ? 87.54%
==================================================
Files ? 250
Lines ? 22675
Branches ? 0
==================================================
Hits ? 19850
Misses ? 1480
Partials ? 1345 |
dahlia
reviewed
May 6, 2020
earlbread
force-pushed
the
preload-failure-chain-reset
branch
from
68546d2
to
7aa65e2
Compare
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
|
I changed the base branch to 0.9-maintenance. |
dahlia
approved these changes
May 6, 2020
longfin
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the canonical chain was changed if executing actions are failed during preload.
The
SwarmTestwas too long, so I separated tests for preload. Please see 18f7245 for the actual change.