Dispose iterator after use #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
previously approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## 0.9-maintenance #870 +/- ##
===================================================
+ Coverage 87.55% 87.56% +0.01%
===================================================
Files 250 250
Lines 22675 22675
===================================================
+ Hits 19853 19856 +3
+ Misses 1476 1473 -3
Partials 1346 1346
|
riemannulus
previously approved these changes
May 19, 2020
dahlia
reviewed
May 19, 2020
longfin
previously approved these changes
May 19, 2020
earlbread
dismissed stale reviews from longfin, riemannulus, and moreal
via
8de6b07
earlbread
force-pushed
the
fix-iterator-dispose
branch
from
42d1ad9
to
8de6b07
Compare
|
I changed the base to 0.9-maintenance and added a changelog. |
longfin
previously approved these changes
May 20, 2020
moreal
previously approved these changes
May 20, 2020
riemannulus
previously approved these changes
May 20, 2020
dahlia
reviewed
May 20, 2020
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>
dahlia
approved these changes
May 20, 2020
riemannulus
approved these changes
May 20, 2020
longfin
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.