Expose exception in IAction.Execute() #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/860
branch
2 times, most recently
from
712e68b
to
bdb5711
Compare
longfin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
- Coverage 87.56% 87.44% -0.13%
==========================================
Files 250 250
Lines 22685 22733 +48
==========================================
+ Hits 19865 19878 +13
- Misses 1475 1523 +48
+ Partials 1345 1332 -13
|
earlbread
previously approved these changes
May 21, 2020
riemannulus
previously approved these changes
May 21, 2020
dahlia
reviewed
May 21, 2020
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>
earlbread
previously approved these changes
May 21, 2020
dahlia
reviewed
May 21, 2020
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>
riemannulus
approved these changes
May 21, 2020
dahlia
approved these changes
May 21, 2020
earlbread
approved these changes
May 21, 2020
moreal
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #860. specifically, it has the following changes.
IAction.RenderError()andIAction.UnrenderError()to report an exception raised byIAction.Execute()to game developer.ActionEvalution.Exceptionto record whether an exception occurred while executing an action.ActionEvalution.EvaluateActionsGradually()(and related methods) no longer throwUnexpectedlyTerminatedActionException. instead, they record it toActionEvaluations.