Add render option to BlockChain<T>() constructor #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
reviewed
May 28, 2020
earlbread
force-pushed
the
allow-render
branch
2 times, most recently
from
bb75f9e
to
75ba39b
Compare
Codecov Report
@@ Coverage Diff @@
## 9c-beta #883 +/- ##
===========================================
- Coverage 87.51% 87.25% -0.27%
===========================================
Files 251 247 -4
Lines 22826 22184 -642
===========================================
- Hits 19977 19357 -620
+ Misses 1517 1500 -17
+ Partials 1332 1327 -5
|
dahlia
reviewed
May 28, 2020
dahlia
reviewed
May 28, 2020
dahlia
reviewed
May 28, 2020
riemannulus
previously approved these changes
May 28, 2020
moreal
previously approved these changes
May 28, 2020
dahlia
reviewed
May 28, 2020
dahlia
changed the title
dahlia
previously approved these changes
May 28, 2020
moreal
previously approved these changes
May 28, 2020
riemannulus
previously approved these changes
May 28, 2020
github-actions
bot
force-pushed
the
allow-render
branch
from
4854275
to
f8a1ee4
Compare
dahlia
reviewed
May 29, 2020
longfin
previously approved these changes
May 29, 2020
dahlia
approved these changes
May 29, 2020
longfin
approved these changes
May 29, 2020
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 23, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 23, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 23, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 24, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 24, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 24, 2020
Because without the render option, the same behaviour can be achieved by using non renderers. See also planetarium#883
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 27, 2020
This implements the equivalent optimization made by the following issue: planetarium#883 Fixes planetarium#967
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 28, 2020
This implements the equivalent optimization made by the following issue: planetarium#883 Fixes planetarium#967
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 28, 2020
This implements the equivalent optimization made by the following issue: planetarium#883 Fixes planetarium#967
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Aug 28, 2020
This implements the equivalent optimization made by the following issue: planetarium#883 Fixes planetarium#967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
allowRenderoption toBlockChain<T>.