Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RocksDBStore.DeleteChainId() idempotent #891

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Make RocksDBStore.DeleteChainId() idempotent #891

merged 2 commits into from
Jun 2, 2020

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Jun 2, 2020

According to IStore.DeleteChainId() method's XML comment:

If there is no such chainId it does nothing.

Howver, RocksDBStore.DeleteChainId() hadn't been like that. This fixed the bug.

@dahlia dahlia added the bug Something isn't working label Jun 2, 2020
@dahlia dahlia self-assigned this Jun 2, 2020
longfin
longfin previously approved these changes Jun 2, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 2, 2020 •
edited
Loading

Codecov Report

Merging #891 into 0.9-maintenance will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           0.9-maintenance     #891      +/-   ##
===================================================
- Coverage            87.66%   87.63%   -0.04%     
===================================================
  Files                  251      251              
  Lines                22756    22767      +11     
===================================================
+ Hits                 19950    19951       +1     
- Misses                1461     1471      +10     
  Partials              1345     1345
Impacted Files Coverage Δ
Libplanet.RocksDBStore/RocksDBStore.cs 95.56% <100.00%> (+0.04%) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.55% <100.00%> (+<0.01%) ⬆️
Libplanet.Tests/Net/Protocols/TestTransport.cs 76.68% <0.00%> (-0.62%) ⬇️
Libplanet/Net/Swarm.cs 84.91% <0.00%> (-0.52%) ⬇️

@dahlia dahlia requested review from earlbread and longfin June 2, 2020 08:58
@longfin longfin merged commit 554692b into planetarium:0.9-maintenance Jun 2, 2020
longfin pushed a commit that referenced this pull request Jun 2, 2020
@dahlia
Merge back 0.9.4 into 9c-beta (#895)
bc93e84 
* Version bump

* Make RocksDBStore.DeleteChainId() idempotent (#891)

* Make RocksDBStore.DeleteChainId() idempotent

* Fix RocksDBStore's incorrect log context

* Release 0.9.4 (#892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longfin longfin longfin approved these changes

@earlbread earlbread earlbread approved these changes

@riemannulus riemannulus riemannulus approved these changes

@moreal moreal Awaiting requested review from moreal

Assignees

@dahlia dahlia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dahlia @longfin @earlbread @riemannulus