Introduce Version property to messages #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
requested review from
dahlia,
longfin,
earlbread,
riemannulus and
moreal
limebell
force-pushed
the
feature/message-apv
branch
from
6195dba
to
72e59c3
Compare
limebell
force-pushed
the
feature/message-apv
branch
from
72e59c3
to
cc96e7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #949 +/- ##
==========================================
- Coverage 88.22% 88.18% -0.04%
==========================================
Files 280 282 +2
Lines 25458 25524 +66
==========================================
+ Hits 22460 22509 +49
- Misses 1532 1539 +7
- Partials 1466 1476 +10
|
riemannulus
previously approved these changes
Aug 10, 2020
|
/rebase |
earlbread
reviewed
Aug 10, 2020
longfin
reviewed
Aug 10, 2020
dahlia
reviewed
Aug 10, 2020
limebell
force-pushed
the
feature/message-apv
branch
from
b9a1c32
to
e5b1f22
Compare
longfin
previously approved these changes
Aug 10, 2020
earlbread
previously approved these changes
Aug 10, 2020
limebell
force-pushed
the
feature/message-apv
branch
from
e5b1f22
to
ceb703e
Compare
Co-authored-by: Seunghun Lee <waydi1@gmail.com>
limebell
force-pushed
the
feature/message-apv
branch
from
d461189
to
90efdcb
Compare
limebell
force-pushed
the
feature/message-apv
branch
from
90efdcb
to
d8e79f0
Compare
earlbread
previously approved these changes
Aug 14, 2020
longfin
previously approved these changes
Aug 14, 2020
dahlia
previously approved these changes
Aug 14, 2020
longfin
dismissed stale reviews from dahlia, earlbread, and themself
via
25d36f0
longfin
approved these changes
Aug 14, 2020
earlbread
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Peer.AppProtocolVersionwhich were used to check version between swarms. Instead, addedAppProtocolVersion-typedVersionproperty toMessageand use it to check validity of messages.If received message has different app protocol version,
NetMQTransportwill reply aDifferentVersionmessage regardless of received message's type and does not process anything.