Make QuerySession more opaque #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
querysession
branch
from
d34accc to
edfe7fd
Compare
iheanyi
reviewed
Aug 2, 2022
We intentionally don't want or need to surface types within the QuerySession type. We likely will change what this is and it's intended to simply be echo'd back, whatever it is. So converting it to simply a type alias for `object` seems to be the right move.
mattrobenolt
force-pushed
the
querysession
branch
from
edfe7fd to
57c2834
Compare
iheanyi
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intentionally don't want or need to surface types within the
QuerySession type. We likely will change what this is and it's intended
to simply be echo'd back, whatever it is. So converting it to simply a
type alias for
unknownseems to be the right move.First TypeScript ever btw. Please tell me if I have no idea what I'm doing.