Make Client stateless, add Connection class for querying #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request takes away the management of sessions from the Client and pushes that responsibility down to the new
Connectionclass. This way, we can have multiple connections per-client, with client inherently becoming stateless. If a connection needs to be re-used, then users can query directly from the connection itself and it's session will be persisted across transactions and such.I also removed the
try/catchblock fromexecute. If something unexpected goes wrong, I think we should bubble that up to the user and let them figure out how they want to handle it. I'm wondering if we should do something forpostJSONas well, to be honest.