Skip to content

Rename mysqlAddress to host #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Rename mysqlAddress to host #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { utf8Encode } from './text.js'
export interface Credentials {
username: string
password: string
mysqlAddress: string
host: string
}

export interface QueryResultRow {
Expand Down Expand Up @@ -92,13 +92,13 @@ export class Connection {
}

private async createSession(): Promise<QuerySession> {
const url = `${this.credentials.mysqlAddress}/psdb.v1alpha1.Database/CreateSession`
const url = new URL('/psdb.v1alpha1.Database/CreateSession', `https://${this.credentials.host}`)
const { session } = await this.postJSON<QueryExecuteResponse>(url)
this.session = session
return session
}

private async postJSON<T>(url: string, body = {}): Promise<T> {
private async postJSON<T>(url: string | URL, body = {}): Promise<T> {
const auth = btoa(`${this.credentials.username}:${this.credentials.password}`)
const response = await fetch(url, {
method: 'POST',
Expand All @@ -120,7 +120,7 @@ export class Connection {

async execute(query: string): Promise<ExecutedQuery> {
const startTime = Date.now()
const url = `${this.credentials.mysqlAddress}/psdb.v1alpha1.Database/Execute`
const url = new URL('/psdb.v1alpha1.Database/Execute', `https://${this.credentials.host}`)
const saved = await this.postJSON<QueryExecuteResponse>(url, {
query: query,
session: this.session
Expand Down