Better support for NULLs #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, both bugs fixed here are the result of protojson encoding and fields being omitted from the JSON response: In the case of a NULL column, the NULL type is omitted from the types enum becasue it's numeric value is "0", and protojson omits this due to it being a default value. In the case of `select null`, we get another edge case, where the `values` itself is entirely omitted due to it being an empty seuqence of bytes. Fixes #72
mattrobenolt
commented
Nov 10, 2022
dgraham
reviewed
Nov 18, 2022
Co-authored-by: David Graham <david.malcom.graham@gmail.com>
iheanyi
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, both bugs fixed here are the result of protojson encoding and fields being omitted from the JSON response:
In the case of a NULL column, the NULL type is omitted from the types enum becasue it's numeric value is "0", and protojson omits this due to it being a default value.
In the case of
select null, we get another edge case, where thevaluesitself is entirely omitted due to it being an empty sequence of bytes. This case is exaggerated for sure, but it is likely to happen if an entire row is simply 1 column of NULL, or even multiple NULLs. So something like,select foo from tablemay yield if too iffoois allowed to be NULL.Fixes #72