Skip to content

Cast as execute option #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 6, 2023
Merged

Cast as execute option #81

merged 6 commits into from
Mar 6, 2023

Conversation

cdcarson
Copy link
Contributor

Implements #80, i.e. adding cast optionally to ExecuteOptions:

const result = connOrTx.execute(query, values, { as: 'object',  cast: myOneOffCastFn })

Notes:

  • I don't believe this is a breaking change.
  • I added a test & all the tests pass.

@iheanyi iheanyi enabled auto-merge March 6, 2023 22:39
@iheanyi iheanyi merged commit 279a6fe into planetscale:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@iheanyi iheanyi iheanyi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcarson @iheanyi