feat: allow subroutines to decide on the finalizer considering the instance

[nexus49]

Context

Sometimes a subroutine will only selectively set a finalizers and needs to consider values on the instance for that decision.

Summary by CodeRabbit

• Refactor
  • Made finalizer processing instance-aware to improve accuracy and consistency during resource lifecycle operations. No changes to user workflows or configuration. Upgrade is seamless.
• Tests
  • Updated tests to validate instance-aware finalizer behavior while preserving existing scenarios and outcomes.
• Chores
  • Internal alignment of lifecycle components on the new instance-aware approach, preparing for future enhancements without affecting current functionality.

[coderabbitai]

Walkthrough

Method signature Finalizers() is updated to Finalizers(instance runtimeobject.RuntimeObject) across the lifecycle controller, its subroutine interface, implementations, and tests. Call sites now pass the instance argument. No other logic or behavior changes are introduced.

Changes

Cohort / File(s)	Summary
Lifecycle controller updates controller/lifecycle/lifecycle.go	Refactors all calls to subroutine.Finalizers() to subroutine.Finalizers(instance); updates contains/remove/add finalizer helpers accordingly.
Subroutine interface change controller/lifecycle/subroutine/subroutine.go	Changes Subroutine interface: Finalizers() → Finalizers(instance runtimeobject.RuntimeObject) []string.
Lifecycle tests adaptation controller/lifecycle/lifecycle_test.go	Updates tests to pass instance to Finalizers and related assertions.
Test support: single subroutine controller/testSupport/finalizerSubroutine.go	Updates FinalizerSubroutine method signature to Finalizers(_ runtimeobject.RuntimeObject) []string; body unchanged.
Test support: multiple subroutines controller/testSupport/testSupport.go	Updates Finalizers signatures for ChangeStatusSubroutine, AddConditionSubroutine, FailureScenarioSubroutine, ContextValueSubroutine to accept instance; bodies unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly captures the core enhancement—subroutines can now use the provided instance when determining finalizers—and aligns with conventional commit style without unnecessary detail.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/pass-instance-to-get-name

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}