Support net: upload port #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support net:host:port upload port as it is supported by avrdude. See http://www.nongnu.org/avrdude/user-manual/avrdude_4.html#Option-Descriptions "-P port" description. See https://community.platformio.org/t/flash-via-tcp-to-uart-bridge/880/7 for the discussion
Support net: upload port
ivankravets
reviewed
Apr 15, 2017
builder/main.py
Outdated
| else: | ||
| if not upload_options.get("disable_flushing", False): | ||
| if not upload_options.get("disable_flushing", False) \ | ||
| and not env.get("UPLOAD_PORT").startswith("net:"): |
There was a problem hiding this comment.
Please replace this line with and not env.get("UPLOAD_PORT", "").startswith("net:") to avoid exception when UPLOAD_PORT is not available
|
Thanks a lot for PR! |
|
You're welcome, I'm glad I can contribute something. |
|
Do you have any ideas as for the #44? I see a few different report about Wire & 1-Wire that project works with Arduino IDE but doesn't work with PIO :( |
|
Not really. I will try and reproduce it with a dallas onewire sensor later today. |
|
Thanks! If we fix that issue, I'll release a new version of dev platform. |
|
I tested with a Dallas DS18B20 temperature sensor which depends on OneWire
with a pro8MHzatmega328 board, but could not reproduce the issue. Behavior
is identical in Arduino IDE and PlatformIO. Unfortunately I do not have a
nano device and sensor to reproduce correctly.
…On Sat, Apr 15, 2017 at 11:32 AM, Ivan Kravets ***@***.***> wrote:
Thanks! If we fix that issue, I'll release a new version of dev platform.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF-eRwQ7Hagz7yWXQUijN66DauzqjwBiks5rwI7KgaJpZM4M-Lbr>
.
|
|
@freynder Thanks a lot for your test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support net:host:port upload port as it is supported by avrdude.
See http://www.nongnu.org/avrdude/user-manual/avrdude_4.html#Option-Descriptions "-P port" description.
See https://community.platformio.org/t/flash-via-tcp-to-uart-bridge/880/7 for the discussion