Add bad change to test clang-tidy #1
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
8 times, most recently
from
33fe243 to
5f92e09
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
5f92e09 to
821b518
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
47121df to
821b518
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
821b518 to
d8b46f4
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
d8b46f4 to
7c53c91
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
7c53c91 to
d6e9e74
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
4 times, most recently
from
26c167c to
07e5e2f
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 206 206
=========================================
Hits 206 206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
05c94a7 to
b065a9d
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
b065a9d to
3d42f52
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
3d42f52 to
80f8b18
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
80f8b18 to
4285a52
Compare
platisd
force-pushed
the
bad_change_to_test_clang-tidy-action
branch
from
4285a52 to
2e32f19
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -175,7 +175,7 @@ template <class... Ts> | |||
| class ArrayWrapper | |||
| { | |||
| public: | |||
| explicit constexpr ArrayWrapper(Ts... ts) | |||
| constexpr ArrayWrapper(Ts... ts) | |||
There was a problem hiding this comment.
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
Suggested change
| constexpr ArrayWrapper(Ts... ts) | |
| constexpr explicit ArrayWrapper(Ts... ts) |
Comment on lines
+314
to
316
| } else { | ||
| return sizeof...(Args); | ||
| } |
There was a problem hiding this comment.
do not use else after return
Suggested change
| } else { | |
| return sizeof...(Args); | |
| } | |
| } return sizeof...(Args); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.