Fetch googletest during cmake configuration #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stop version controlling gooogletest * Bump googletest to 1.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CMake configuration to fetch GoogleTest during the configuration process instead of including it directly in the project. This change will make it easier to manage the project's dependencies, as the latest version of GoogleTest will always be fetched during the build process.
Specifically, this pull request adds
FetchContent_DeclareandFetchContent_MakeAvailabletoexternal/CMakeLists.txtto fetch GoogleTest. It also removes theadd_subdirectorycommand from the same file, which was previously used to add GoogleTest directly to the build.Overall, this change will improve the maintainability of the project by making it easier to manage dependencies and ensuring that the latest version of GoogleTest is always used.