Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate goals with sites, not domains #2828

Merged
merged 6 commits into from
Apr 10, 2023
Merged

Associate goals with sites, not domains #2828

merged 6 commits into from
Apr 10, 2023

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Apr 6, 2023

Changes

With #2803, we've overlooked the fact that goals were being created with domain instead of site's foreign key. This PR addresses that. Requires a staged postgres migration partially introduced in #2833 first - only then I'll rebase this PR and re-enable goals creation.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

lib/plausible/goal/schema.ex Outdated Show resolved Hide resolved
@aerosol aerosol changed the title wip Fix goals Apr 6, 2023
@bundlemon
Copy link

bundlemon bot commented Apr 6, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
297.58KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
733B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aerosol aerosol mentioned this pull request Apr 7, 2023
8 tasks
@aerosol aerosol marked this pull request as ready for review April 7, 2023 05:42
@aerosol aerosol changed the title Fix goals Associate goals with sites, not domains Apr 7, 2023
@aerosol aerosol mentioned this pull request Apr 10, 2023
8 tasks
@aerosol aerosol merged commit c04e928 into master Apr 10, 2023
@aerosol aerosol deleted the fix-goals branch April 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants