-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple filters on the frontend #4174
Conversation
5f87125
to
89e3e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I would like to discuss which filter types will be available to the client
} | ||
if (operation == FILTER_OPERATIONS.contains) { | ||
clauses = clauses.map((value) => value.includes('*') ? value : `**${value}**`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to go in the direction that matches
is a first-class operation that would also be available in the API. Am I reading it right?
My thinking on what filters should be available to client:
is
- can deal with lists like you've already done in this PR. Can also take wildcards.contains
- equivalent tois
where value is wrapped with*${value}*
I'm not sure about exposing matches
for simple wildcards. It would fit better for a full regex match filter operation in the future.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I completely understood. Created https://3.basecamp.com/5308029/buckets/37310803/card_tables/cards/7494308360 for this discussion so it doesn't get dropped.
Note this is not yet final, but this scaffolding will soon be used
This helps ensure we can be consistent/simple with apiv2
Changes
This PR does a few things:
multiple_filters
feature flag which allows adding multiple filters on the frontend (except for goals).Blocked on #4118 - will update filtering within after that PR lands.
Tests
Changelog
Documentation
Dark mode