Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Multiple filters on the frontend (#4174)" #4218

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Revert "Multiple filters on the frontend (#4174)" #4218

merged 1 commit into from
Jun 11, 2024

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Jun 11, 2024

This reverts commit e1f0002.

cc @macobo - see sentry/city filters

macobo
macobo approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. For reference the issue seems to be in quoting/not quoting city/region ids.

@macobo macobo merged commit 2f7dcae into master Jun 11, 2024
8 checks passed
macobo added a commit that referenced this pull request Jun 11, 2024
@macobo
Revert "Revert "Multiple filters on the frontend (#4174)" (#4218)"
610fe0a 
This reverts commit 2f7dcae.
@macobo macobo mentioned this pull request Jun 11, 2024
Merged
macobo added a commit that referenced this pull request Jun 13, 2024
@macobo
Re-apply multiple filters in FE (#4219)
7752039 
* Revert "Revert "Multiple filters on the frontend (#4174)" (#4218)"

This reverts commit 2f7dcae.

* Make city links work again

By enforcing everything sent to the BE is stringified. We do this at serialization-time to ensure old dashboard links still work
@aerosol aerosol deleted the revert-e1f0002d2ebcfae2145001b1c3957158f39e4792 branch July 12, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aerosol @macobo