Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create seeders #88

Merged
merged 15 commits into from
May 13, 2018
Merged

Create seeders #88

merged 15 commits into from
May 13, 2018

Conversation

adabarx
Copy link

@adabarx adabarx commented Apr 24, 2018

The seeder is able to generate data for every part of the database.

itsrachelfish
itsrachelfish requested changes May 13, 2018
View reviewed changes
Copy link
Member

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to run this locally but it looks like the score factory wasn't committed?

@itsrachelfish
Copy link
Member

missing-score-factory

Error I got when running locally

itsrachelfish
itsrachelfish approved these changes May 13, 2018
View reviewed changes
Copy link
Member

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted 99728de7422d1c160feb00b4655ee3b77ae0d6f0 to recreate the scaffolding for the score factory, this fixed the error in the screenshot. 👍

@itsrachelfish itsrachelfish merged commit 77cdc48 into master May 13, 2018
@itsrachelfish itsrachelfish mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsrachelfish itsrachelfish itsrachelfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adabarx @itsrachelfish