Shadow intensity #4346
Merged
Shadow intensity #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports spot, omni and point lights. Updated the lights.tsx to add controls for the shadow intensities. Shadow is calculated as a separate variable, and then 1 -> shadow is lerped with intensity value.
Supports spot, omni and point lights. Updated the lights.tsx to add controls for the shadow intensities. Shadow is calculated as a separate variable, and then 1 -> shadow is lerped with intensity value.
…ngine into gsterbrant_shadow_intensity # Conflicts: # src/framework/components/light/component.js
|
Realized I had this branched on an old version of main. Going to do a rebase and work this code in again. |
|
Very cool! So a few comments/suggestion:
|
omni = point? |
mvaligursky
reviewed
Jun 21, 2022
Supports spot, omni and point lights. Updated the lights.tsx to add controls for the shadow intensities. Shadow is calculated as a separate variable, and then 1 -> shadow is lerped with intensity value.
mvaligursky
reviewed
Jun 21, 2022
Supports spot, omni and point lights. Updated the lights.tsx to add controls for the shadow intensities. Shadow is calculated as a separate variable, and then 1 -> shadow is lerped with intensity value.
…ngine into gsterbrant_shadow_intensity # Conflicts: # src/framework/components/light/component.js # src/graphics/program-lib/programs/standard.js
Also removing the default setting for ambient bake lights. Clustered lights needs more work, seeing as we use a parameter texture and will have to steal a slot from COOKIE_A to store the shadow intensity.
|
This is awesome! Please create an issue on editor repo so we don't forget to expose this functionality in the editor when engine is released. |
|
This issue relates to adding support for this in the editor. |
mvaligursky
approved these changes
Jun 21, 2022
|
@GSterbrant Ah, you probably need to add Line 180 in de890ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports spot, point/omni and directional lights.
Updated the lights.tsx example to add controls for the shadow intensities.
Shadow is calculated as a separate variable, and then 1 -> shadow is lerped with intensity value.
API changes:
Lights have a new member
shadowIntensity.Fixes #3604
