Fix depth linearization #4360
Merged
Fix depth linearization #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, great to see this fixed. As an aside, I'm wondering whether the chessboard @mvaligursky added would be a much better scene to show off post effects (particularly bokeh). (I'm not suggesting this should be addressed in this PR though!). |
Actually, orthographic projection already stores the depth linearly, so all we need to do is to scale it back so it's between near and far plane. As for perspective projection, since the depth is already in normalized space [0, 1], there should be no need to move it back to NDC coordinates since we don't want the depth in -1, 1 when we output. One unfortunate effect is that we are more or less forced to branch on a uniform since the shader has no awareness of the type of projection being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3411
Linearization of the depth buffer was done incorrectly, however it produced coherently variant results with a perspective projection, but not with an orthogonal one. That resulted in post effects linearizing depth producing incorrect results, such as the SSAO:
effect.
With this PR, the results are more correct: