Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing sky for Editor #5901

Merged
merged 7 commits into from Dec 19, 2023
Merged

Exposing sky for Editor #5901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
796d96a
Added new properties to scene for new skybox
kpal81xd Dec 18, 2023
96fe6ec
Reordered scene setting skybox scale definition
kpal81xd Dec 18, 2023
2b3f673
Removed forwarding of skyType component - already exposed in sky
kpal81xd Dec 18, 2023
c3fb11a
Moved applying properties for position, scale and tripod to applySett…
kpal81xd Dec 18, 2023
f84401d
set position and scale properties directy onto node in sky; renamed t…
kpal81xd Dec 18, 2023
6cb5ad6
added node rotation setting
kpal81xd Dec 18, 2023
7e196c7
Rename sky mesh properties to include mesh in their names
kpal81xd Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/scene/scene.js
View file
Open in desktop
Expand Up @@ -702,6 +702,8 @@ class Scene extends EventHandler {
this.skyboxRotation = (new Quat()).setFromEulerAngles(render.skyboxRotation[0], render.skyboxRotation[1], render.skyboxRotation[2]);
}

this.sky.applySettings(render);

this.clusteredLightingEnabled = render.clusteredLightingEnabled ?? false;
this.lighting.applySettings(render);

Expand Down
10 changes: 10 additions & 0 deletions src/scene/skybox/sky.js
View file
Open in desktop
Expand Up @@ -59,6 +59,16 @@ class Sky {
this.projectedSkydomeCenterId = this.device.scope.resolve('projectedSkydomeCenter');
}


applySettings(render) {
this.node.setLocalPosition(new Vec3(render.skyMeshPosition ?? [0, 0, 0]));
this.node.setLocalEulerAngles(new Vec3(render.skyMeshRotation ?? [0, 0, 0]));
this.node.setLocalScale(new Vec3(render.skyMeshScale ?? [1, 1, 1]));
if (render.skyCenter) {
this._center = new Vec3(render.skyCenter);
}
}

/**
* The type of the sky. One of the SKYMESH_* constants. Defaults to {@link SKYTYPE_INFINITE}.
* Can be:
Expand Down