Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Scalafmt settings between all repositories #227

Open
30 tasks
ihostage opened this issue May 18, 2022 · 4 comments · May be fixed by playframework/.github#28
Open
30 tasks

Sync Scalafmt settings between all repositories #227

ihostage opened this issue May 18, 2022 · 4 comments · May be fixed by playframework/.github#28

Comments

@ihostage
Copy link
Member Author

Ok, let's go discuss what settings should be 😄

@octonato
Copy link
Contributor

I don't know if that's necessary. Is that such a big deal if they are not everywhere the same?

Imagine if we change it in one of the projects and it get synch'ed everywhere. Now we will have PRs everywhere that will require manual intervention because PRs will fail due to formatting.

@ihostage
Copy link
Member Author

ihostage commented Jun 9, 2022

I'm sure that we should have an unified format settings for all repos. I see a problem only with bump of version, because sometimes Steward do something more than just change a config 😞

@ihostage
Copy link
Member Author

ihostage commented Jun 9, 2022

Of course we can synchronize configs between repos manually one time and then Steward will just bump versions periodically. But I think we also need an automate sync, that will light us when something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants