New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9942: correct example html and the hello world doc #9945

Closed

ranmx wants to merge 1 commit into playframework:master from ranmx:bugfix_hello

ranmx commented Dec 24, 2019

Pull Request Checklist

Have you read How to write the perfect pull request?
Have you read through the contributor guidelines?
Have you signed the Lightbend CLA?
Have you referenced any issues you're fixing using commit message keywords?
Have you added copyright headers to new files?
Have you checked that both Scala and Java APIs are updated?
Have you updated the documentation for both Scala and Java sections?
Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #9942 Fixes document not equal to what is shown in example zip

Purpose

correct issue @9942

Background Context

I start to learn playframe work today so I copy from index.scala.html

References

nop


          change example html and the helloworld markdown

99443ae

lightbend-cla-validator commented Dec 24, 2019

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

ranmx closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet