feat: support Har recording option (#253) #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaushi
force-pushed
the
support-har-recording
branch
from
3f3e47a to
d0c179c
Compare
masaushi
commented
Apr 29, 2022
| } | ||
|
|
||
| func (p *pageImpl) Video() Video { | ||
| p.Lock() |
There was a problem hiding this comment.
This isn't related to the issue #253, but for race condition detected in a CI test.
https://github.com/playwright-community/playwright-go/runs/6224590861
masaushi
force-pushed
the
support-har-recording
branch
from
bb34ab2 to
6271693
Compare
masaushi
commented
Apr 29, 2022
Comment on lines
+34
to
+52
| - name: Cache modules and build | ||
| uses: actions/cache@v3 | ||
| with: | ||
| # In order: | ||
| # * Module download cache | ||
| # * Build cache (Linux) | ||
| # * Build cache (Mac) | ||
| # * Build cache (Windows) | ||
| path: | | ||
| ~/go/pkg/mod | ||
| ~/.cache/go-build | ||
| ~/Library/Caches/go-build | ||
| %LocalAppData%\go-build | ||
| key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-go- | ||
| - name: Download modules | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: go mod download |
There was a problem hiding this comment.
Some tests on github actions are randomly failed because of timed out of test execution.
I tried to fix them but I didn't find out the root cause, and even now I don't know any solution.
My trials were extending test executing time and caching dependencies, and unfortunately both of them were ineffective.
But I think caching is valuable so the cache setting is remained.
mxschmitt
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds support for Har recording option.
Related issue is #253.