Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some code using the new stdlib and generics, and add several tests #404

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Refactor some code using the new stdlib and generics, and add several tests #404

merged 4 commits into from
Jan 9, 2024

Conversation

canstand
Copy link
Collaborator

@canstand canstand commented Jan 8, 2024 •
edited
Loading

note:

  • golang.org/x/exp/slices in event_emitter.go
  • generics in tests/helper_test.go
  • atomic.Uint32 in connection.go

@canstand canstand marked this pull request as ready for review January 8, 2024 12:15
@canstand canstand merged commit 8b2bd7b into playwright-community:main Jan 9, 2024
13 checks passed
@canstand canstand deleted the refac-2 branch January 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canstand @mxschmitt