Add ability to retrieve site hosting properties #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgin
approved these changes
Mar 27, 2017
| 'ip_address', | ||
| ]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add new line at the end of the file.
There was a problem hiding this comment.
BTW in PhpStorm there is a setting Ensure line feed at file end on Save in Editor > General section. It is highly recommended to enable the setting.
| @@ -18,9 +19,22 @@ public function create(array $properties) | |||
|
|
|||
| $infoGeneral = $info->addChild('gen_setup'); | |||
| foreach ($properties as $name => $value) { | |||
| if (!is_scalar($value)) { | |||
There was a problem hiding this comment.
Why there is the filter for gen_setup and there is no filter for hosting? What is the case?
| */ | ||
| public function getHosting($field, $value) | ||
| { | ||
| $items = $this->_getItems(Struct\HostingInfo::class, 'hosting', $field, $value, function ($node) { |
There was a problem hiding this comment.
array_filter($this->_getItems, function ($node) { ... })
mrsombre
pushed a commit
that referenced
this pull request
Aug 2, 2019
…to master * commit 'd87c75af81a587b64e09c97e188a334b696c1b63': FEATURE PPP-30318 Category, CategoryFeatured components FEATURE PPP-30318 Category, CategoryFeatured components
mrsombre
pushed a commit
that referenced
this pull request
Jul 14, 2020
…hange-ruby-version-PPP-19754 to master * commit '928badb8a02f502ca6f2a3df343b367baf9036ed': FEATURE PPP-19754 Add popup for ruby version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.