Skip to content

Add plan-name to Webspace Create Request + Implement create SiteAlias request #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add plan-name to Webspace Create Request + Implement create SiteAlias request #27

wants to merge 3 commits into from

Conversation

dpfaffenbauer
Copy link
Contributor

As the title says:

  • Add plan-name to Webspace Create Request (not the best way of doing it)
  • Implement SiteAlias create Request

@dpfaffenbauer
Copy link
Contributor Author

Is this PR getting reviewed?

@sibprogrammer
Copy link
Member

Yes, but there are some problems.

  1. One needs to follow the rule: one feature - one pull request. So you need split it into two pull requests.
  2. As for planName parameter, seems it's definitely not the best way to do it, but it will work. Providing plan via object requires much more changes. So let's stick w/ planName parameter by now.
  3. As for site alias, first of all you need to squash commits into single one. Also it will be great if you are able to add tests (see "tests" directory).

P.S. Sorry for delay with response.

@dpfaffenbauer
Copy link
Contributor Author

Splitted into two PR #29 and #28

mrsombre pushed a commit that referenced this pull request Aug 2, 2019
@alexeysinko
Merge pull request #27 in PSDK/ext-catalog from task-asinko-add-image…
36d8761 
…-loader-PPP-30318 to master

* commit '7a9ec7ed2ec8eb82f10f6729ab79354c093f8838':
  FEATURE PPP-30318 Add images loader
mrsombre pushed a commit that referenced this pull request Jul 14, 2020
@alexeysinko
Merge pull request #27 in PSDK/ext-ruby from task-asinko-add-nginx-su…
cffaa6a 
…pport-PPP-23671 to master

* commit '0721ba482d7a70acd4ed2348d846fe8567f504ab':
  FEATURE PPP-23671 Add simple nginx config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpfaffenbauer @sibprogrammer