Add detection of arrays with duplicating key values #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Associative arrays convert directly to XML. However, there's no directly convertable array representation that supports duplicate keys, whereas the Plesk XML API requires it.
Therefore indexed arrays should create duplicating 'key' XML elements. Example:
<greeting>
<hi>hola</hi>
<hi>hello</hi>
<hi>bonjour</hi>
</greeting>
Can be represented in array form as:
array('greeting' => array('hi' => array('hola', 'hello', 'bonjour')));
Currently, as far as I can tell, you simply can't pass an array into this library that uses data in this manner, yet <filter> requests often require it.
|
Thanks for your efforts! |
mrsombre
pushed a commit
that referenced
this pull request
Aug 2, 2019
…utotests-PPP-30481 to master * commit 'afc0110e141a4bc785c6ee3601e64719041639b9': BUGFIX PPP-30481 Added data attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associative arrays convert directly to XML. However, there's no directly convertable array representation that supports duplicate keys, whereas the Plesk XML API requires it.
Therefore indexed arrays should create duplicating 'key' XML elements. Example:
<greeting> <hi>hola</hi> <hi>hello</hi> <hi>bonjour</hi> </greeting>Can be represented in array form as:
array('greeting' => array('hi' => array('hola', 'hello', 'bonjour')));Currently, as far as I can tell, you simply can't pass an array into this library that uses data in this manner, yet
<filter>requests often require it.