Update composer.json, removed composer.lock #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrsombre
commented
Nov 26, 2018
mrsombre
commented
- Changed requirements to >= 5.6 (7.3 is coming, don't need to maintain for every php version)
- Added curl and xml modules as requirements
- Switched dev branch to 1.0.x version
- Dropped composer.lock (don't needed for libraries because installation type is dependency for project)
- Updated README to use stable version for composer
|
php version |
xgin
reviewed
Nov 26, 2018
.gitignore
Outdated
| /phpunit.xml | ||
| /composer.lock | ||
| /composer.phar |
There was a problem hiding this comment.
it's your infrastructure, this project does not depend on it - use gitignore_global
xgin
approved these changes
Nov 26, 2018
mrsombre
force-pushed
the
tech-dbarsukov-maintenance
branch
from
31e7e99 to
a296948
Compare
rybalov
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.