Add protected directories management operations #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgin
reviewed
Jun 18, 2019
mrsombre
approved these changes
Jun 19, 2019
| * @param $value | ||
| * @return \PleskX\Api\XmlResponse | ||
| */ | ||
| private function _get($command, $field, $value) |
There was a problem hiding this comment.
Maybe better to move this to \PleskX\Api\Operator, looks like common method?
There was a problem hiding this comment.
Not so common unfortunately due to a lot of minor differences in XML-RPC API itself. But as you can see I did some unification in some other operators for "get" methods and will continue working in this direction.
|
|
||
| static::$_client->protectedDirectory()->delete('id', $protectedDirectory->id); | ||
| } | ||
|
|
There was a problem hiding this comment.
Empty line after class body is not PSR-2 compliant
| @@ -3,9 +3,113 @@ | |||
|
|
|||
| namespace PleskX\Api\Operator; | |||
|
|
|||
| use PleskX\Api\Struct\ProtectedDirectory as Struct; | |||
|
|
|||
| class ProtectedDirectory extends \PleskX\Api\Operator | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
Empty line before class body is not PSR-2 compliant
| $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL); | ||
| return $response; | ||
| } | ||
|
|
There was a problem hiding this comment.
Empty line after class body is not PSR-2 compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.