Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeswitch: small fixes #125

Merged
merged 3 commits into from
Oct 1, 2014
Merged

Conversation

darylyu
Copy link
Contributor

@darylyu darylyu commented Oct 1, 2014

I ran the script today and I have some concerns:

  • Freeswitch is now using a new location for their git repo
  • not comfortable with using the master branch; let's pin it on the stable branch instead
  • I had some missing dependencies and it would still continue

D. Yu added 3 commits October 1, 2014 11:01
Easier if it's pegged at a known stable version instead of
using master all the time and unknowingly using different versions
on different machines.
@mike-plivo
Copy link
Member

Thanks for the changes, merging !

mike-plivo added a commit that referenced this pull request Oct 1, 2014
@mike-plivo mike-plivo merged commit 71dda54 into plivo:master Oct 1, 2014
darylyu added a commit to darylyu/plivoframework that referenced this pull request Oct 7, 2014
This automatically clones from the remote branch instead of doing the branch switch
locally.

The approach introduced in plivo#125 does not work. It was working in the environment I was working on because I automatically did somethings to test the changes convenient. I did *not* test for completely clean machines. The old way would fail, because it's a shallow clone. It only kept one version of the repo's history and *ONLY* for the master branch. This is why it would fail when it switched to the stable branch. I apologize for the trouble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants