Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions for robotframework-browser = 18.8.1 #948

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Update versions for robotframework-browser = 18.8.1 #948

merged 3 commits into from
Sep 17, 2024

Conversation

petschki
Copy link
Member

No description provided.

@mauritsvanrees
Remove versionannotation for prompt-toolkit.
506598c 
Latest robotframework-debuglibrary has no upper bound for it anymore.
It was there in that package for Python 3.5 support.
@mauritsvanrees
Remove version pin for grpcio-tools.
0207fcf 
`robotframework-browser` has this and a few others hardcoded in their `requirements.txt`.
See https://github.com/MarketSquare/robotframework-browser/blob/main/Browser/requirements.txt
They hardcode a few version numbers to keep their CI matrix from bloating.

As long as they do that, we do not need to specify these versions ourselves.
We already have no version pin for their `grpcio` and `protobuf` dependencies.
These dependencies both end up in `bin/test`, and Buildout does not complain about missing version pins, so it is fine.
mauritsvanrees
mauritsvanrees approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have added two small commits, removing the grpcio-tools pin and two version annotations. See commit messages.

@mauritsvanrees mauritsvanrees merged commit b9aef97 into 6.1 Sep 17, 2024
12 of 14 checks passed
@mauritsvanrees mauritsvanrees deleted the robotframework-browser-versionupdates branch September 17, 2024 08:58
@petschki
Copy link
Member Author

petschki commented Sep 17, 2024 •
edited
Loading

rfbrowser init on Jenkins warns that node version is outdated and playwright installation has missing dependencies. See https://jenkins.plone.org/job/plone-6.1-python-3.12-robot-chrome/552/console ... problem?

@mauritsvanrees mauritsvanrees mentioned this pull request Sep 17, 2024
Closed
22 tasks
@gforcada
Copy link
Member

I updated the node version to v20.5.1 is that enough? 🤔

@davisagli
Copy link
Member

@petschki @mauritsvanrees It seems like the robot tests have been much more flaky on Jenkins since this was merged.

This was referenced Oct 3, 2024
Merged
Closed
@petschki petschki restored the robotframework-browser-versionupdates branch October 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petschki @gforcada @davisagli @mauritsvanrees