checkouts.cfg does not get updated anymore. Github token missing?

[mauritsvanrees]

When a PR is merged, the package should be added to checkouts.cfg, but this no longer happens.
Problem should be somewhere in the UpdateCoredevCheckouts subscriber. Looks okay at first glance, but maybe something is in the logs?

The last time the checkouts were successfully updated on 5.1 and 5.2, was on 23 January. On 4.3 it was on 26 December which may be correct: not many changes are coming in. On 6.0 we don't yet update the checkouts automatically.

So last success was 23 January.
Aha, a few days later @gforcada made several changes, so it could be caused by one of those. Mostly version pin updates, but there is one more likely candidate: PR #76 was merged, which uses GitHub token authentication.

@gforcada Is maybe something missing here? Does a new GitHub token need to be stored on the server, or passed along somehow?

I guess production.ini on the server needs to get the new github_token value, instead of github_user and github_password.

[gforcada]

That's supposed to be like that already, I will try to have a look

[gforcada]

@mauritsvanrees do you have a specific example where I can dig on the logs to see if there is a logged error? 🤔

[mauritsvanrees]

plone.app.content is a recent example on 5.2:

• I made a PR: Integrate Plone20200121 hotfix: prevent XSS in title. [master] plone.app.content#193.
• This was merged by @jensens 7 days ago, it seems just by merging it in the GitHub UI: plone/plone.app.content@b7406aa
• Result was this fake commit by mr.roboto, updating last_commit.txt: plone/buildout.coredev@c4ec5ce
• But plone.app.content was not added to the checkouts.
• I manually added it to the checkouts later:
  plone/buildout.coredev@c0e79b6

I did some commits yesterday with the help of plone.releaser, finding various packages with changes that were not in the checkouts. Those commits have the same message (<package> has changes) that mr.roboto would add, but without the [fc] for fake commit in front of it. For example this one: plone/buildout.coredev@bedb2ba

[gforcada]

Thanks! I will try to have a look at night

[mauritsvanrees]

Traceback in the mr.roboto log:

  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 501, in run
    self.add_pacakge_to_checkouts(not_in_checkouts)
  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 518, in add_pacakge_to_checkouts
    self.make_commit(repo, version, user)
  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 534, in make_commit
    checkouts_cfg_file = repo.get_file_contents(filename, head_ref.object.sha)
AttributeError: 'Repository' object has no attribute 'get_file_contents'

[mauritsvanrees]

https://github.com/PyGithub/PyGithub/search?q=get_file_contents

Deprecation

353 | * Repository.get_file_contents() no longer works use Repository.get_contents() instead

[mauritsvanrees]

Fixed.