-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass messages from translate method to get them translated in JSON results used later by folder_contents view #205
Conversation
@erral thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! So those one are already translated in the plone domain.
news/204.bugfix
Outdated
@@ -0,0 +1,2 @@ | |||
Pass messages from translate method to get them translated for folder_contents view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to pass to" instead of "to pass from", and technically translate is a function, not a method.
=> Pass messages to the translate function to get them translated for folder_contents view
@jenkins-plone-org please run jobs |
@erral When jenkins is green, you can merge. |
Oh, I thought mr.roboto was still doing its job silently, anyway I'll do it. Thanks. |
Unfortunately no, there is a comment in |
You may know all this already, but I write it here, this can help others reading the comments. |
Fixes #204