Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass messages from translate method to get them translated in JSON results used later by folder_contents view #205

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

erral
Copy link
Member

@erral erral commented Jul 3, 2020

Fixes #204

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Jul 3, 2020

@jenkins-plone-org please run jobs

Copy link
Member

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So those one are already translated in the plone domain.

news/204.bugfix Outdated
@@ -0,0 +1,2 @@
Pass messages from translate method to get them translated for folder_contents view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to pass to" instead of "to pass from", and technically translate is a function, not a method.
=> Pass messages to the translate function to get them translated for folder_contents view

@erral
Copy link
Member Author

erral commented Jul 3, 2020

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member

@erral When jenkins is green, you can merge.
Once this is merged, you need to add "plone.app.content" in the checkouts.cfg of buildout.coredev so @mauritsvanrees know this package has changes. mr.roboto used to do this automatically once the PR was merged but it's not the case anymore.
Note: lots of packages are already checkout when you use experimental/i18n.cfg but you still need to add the package in checkouts.cfg to know this needs a new release.

@erral
Copy link
Member Author

erral commented Jul 3, 2020

Oh, I thought mr.roboto was still doing its job silently, anyway I'll do it. Thanks.

@vincentfretin
Copy link
Member

Unfortunately no, there is a comment in checkout.cfg about it linking to plone/mr.roboto#79

@vincentfretin
Copy link
Member

You may know all this already, but I write it here, this can help others reading the comments.
Please be sure you do git pull before doing your commit "checkout plone.app.content". Or if you did your commit already and not have already ran git push, run git pull --rebase then git push. This to avoid a merge commit, a fake commit '[fc]' may have happened in between if someone merged another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translations in folder_contents
3 participants