Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added adapter for data wrapped in xmlrpclib.Binary #1

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
Owner

aclark4life commented Oct 19, 2011

Binary content (images, audio, etc) uploaded via XML-RPC needs to be wrapped in xmlrpclib.Binary, but p.a.blob currently does not support this approach, failing with "could not adapt". These commits add an xmlrpclib.Binary adapter.

Owner

witsch commented Oct 19, 2011

Alex, thanks for taking care of this — the diff looks good to me. Would you mind adding a test, though, please? :)

Owner

aclark4life commented Oct 24, 2011

As soon as I can figure out how to run the tests, I will finish this ;-)

Owner

witsch commented Oct 25, 2011

does bin/test -m plone.app.blob not work (in a recent coredev buildout)?

Contributor

garbas commented Nov 23, 2012

@aclark4life any progress on this one?

Owner

aclark4life commented Nov 23, 2012

No, sorry. It works but I don't have time to look into writing a test for it. Anyone who is already familiar with the tests for this package should be able to do it though.

Contributor

garbas commented Nov 23, 2012

any idea how can i contribute to this pull request ... or you need to close it and create new one?

Owner

aclark4life commented Nov 23, 2012

I can merge it and you can continuing working on it, if @witsch doesn't mind.

garbas added a commit that referenced this pull request Nov 25, 2012

@garbas garbas closed this Nov 25, 2012

garbas added a commit that referenced this pull request Nov 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment