Added adapter for data wrapped in xmlrpclib.Binary #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alex, thanks for taking care of this — the diff looks good to me. Would you mind adding a test, though, please? :) |
|
As soon as I can figure out how to run the tests, I will finish this ;-) |
|
does |
|
@aclark4life any progress on this one? |
|
No, sorry. It works but I don't have time to look into writing a test for it. Anyone who is already familiar with the tests for this package should be able to do it though. |
|
any idea how can i contribute to this pull request ... or you need to close it and create new one? |
|
I can merge it and you can continuing working on it, if @witsch doesn't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary content (images, audio, etc) uploaded via XML-RPC needs to be wrapped in xmlrpclib.Binary, but p.a.blob currently does not support this approach, failing with "could not adapt". These commits add an xmlrpclib.Binary adapter.